Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show underlying cause of DynamoDB service error #2541

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

wjones127
Copy link
Contributor

Found this issue while trying to debug LanceDB, but I think a user had reported they were having trouble debugging this feature too.

Previous unhelpful error message:

LanceError(IO): WrappedSdkError: service error, /Users/willjones/.cargo/git/checkouts/lance-b31243ab5673a03e/fb84707/rust/lance-table/src/io/commit/dynamodb.rs:37:23

New error message:

LanceError(IO): WrappedSdkError: request_id: db9807d8-8d17-45d1-973e-babfaf177998, service_error: Response { status: 400, version: HTTP/1.1, headers: {"content-type": "application/json", "x-amzn-errortype": "ResourceNotFoundException", "content-length": "98", "x-amzn-requestid": "db9807d8-8d17-45d1-973e-babfaf177998", "x-amz-crc32": "137764666", "connection": "close", "date": "Thu, 27 Jun 2024 16:05:49 GMT", "server": "hypercorn-h11"}, body: SdkBody { inner: Once(Some(b"{\"__type\": \"ResourceNotFoundException\", \"message\": \"Cannot do operations on a non-existent table\"}")), retryable: true } }, /Users/willjones/Documents/lance/rust/lance-table/src/io/commit/dynamodb.rs:38:23

@github-actions github-actions bot added the bug Something isn't working label Jun 27, 2024
@wjones127 wjones127 changed the title fix: better DynamoDB error message fix: show underlying cause of DynamoDB error Jun 27, 2024
@wjones127 wjones127 changed the title fix: show underlying cause of DynamoDB error fix: show underlying cause of DynamoDB service error Jun 27, 2024
Copy link
Contributor

@chebbyChefNEQ chebbyChefNEQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.78%. Comparing base (e631644) to head (e895cab).

Files Patch % Lines
rust/lance-table/src/io/commit/dynamodb.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2541      +/-   ##
==========================================
- Coverage   79.80%   79.78%   -0.03%     
==========================================
  Files         207      207              
  Lines       59585    59590       +5     
  Branches    59585    59590       +5     
==========================================
- Hits        47552    47542      -10     
- Misses       9253     9259       +6     
- Partials     2780     2789       +9     
Flag Coverage Δ
unittests 79.78% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjones127 wjones127 merged commit acf750a into lancedb:main Jun 27, 2024
24 of 25 checks passed
@wjones127 wjones127 deleted the fix/better-dynamodb-sdk-error branch June 27, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants