Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: flat search to use datafusion top k #2535

Merged
merged 10 commits into from
Jun 27, 2024
Merged

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Jun 26, 2024

Closes #1324

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 76.57658% with 26 lines in your changes missing coverage. Please review.

Project coverage is 79.78%. Comparing base (2926fde) to head (2696b8c).
Report is 1 commits behind head on main.

Files Patch % Lines
rust/lance-index/src/vector/flat.rs 18.18% 6 Missing and 3 partials ⚠️
rust/lance/src/dataset/scanner.rs 67.85% 1 Missing and 8 partials ⚠️
rust/lance/src/io/exec/knn.rs 88.88% 3 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2535      +/-   ##
==========================================
- Coverage   79.80%   79.78%   -0.02%     
==========================================
  Files         207      207              
  Lines       59636    59569      -67     
  Branches    59636    59569      -67     
==========================================
- Hits        47591    47529      -62     
+ Misses       9261     9254       -7     
- Partials     2784     2786       +2     
Flag Coverage Δ
unittests 79.78% <76.57%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -34,56 +23,19 @@ fn distance_field() -> ArrowField {

#[instrument(level = "debug", skip_all)]
pub async fn flat_search(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: this method name doesn't match what it does since this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, fixed.

@eddyxu eddyxu merged commit f8c5f4d into main Jun 27, 2024
21 of 22 checks passed
@eddyxu eddyxu deleted the lei/refactor_search branch June 27, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use TopK node for KNN
4 participants