Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build HNSW with wrong distance type #2533

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

BubbleCal
Copy link
Contributor

No description provided.

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@BubbleCal BubbleCal requested a review from eddyxu June 26, 2024 13:30
@github-actions github-actions bot added the bug Something isn't working label Jun 26, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.67%. Comparing base (0dbfc7c) to head (a2789b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2533   +/-   ##
=======================================
  Coverage   79.66%   79.67%           
=======================================
  Files         207      207           
  Lines       59179    59171    -8     
  Branches    59179    59171    -8     
=======================================
- Hits        47147    47142    -5     
+ Misses       9256     9247    -9     
- Partials     2776     2782    +6     
Flag Coverage Δ
unittests 79.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little nervous about merging a bug fix without a unit test. Is there a way to catch an issue like this in a test?

@BubbleCal
Copy link
Contributor Author

I'm a little nervous about merging a bug fix without a unit test. Is there a way to catch an issue like this in a test?

It seems there's no good way to verify it because we won't store the flat storage. I guess we can verify it by recall, and we do have tests for this, but for small dataset it's always enough (>=0.9) even passed wrong distance type.

@BubbleCal BubbleCal requested a review from wjones127 June 27, 2024 01:54
@BubbleCal BubbleCal merged commit 2c7f213 into lancedb:main Jun 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants