Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(java): enable separate java builds #2457

Merged
merged 8 commits into from
Jun 23, 2024
Merged

Conversation

LuQQiu
Copy link
Collaborator

@LuQQiu LuQQiu commented Jun 9, 2024

The java build with full java 8 / 11 / 17 compile and tests takes a long time.
This PR separate the builds so that they can be paralleled

@github-actions github-actions bot added the chore label Jun 9, 2024
@LuQQiu LuQQiu requested review from QianZhu and eddyxu June 9, 2024 05:27
@QianZhu
Copy link
Contributor

QianZhu commented Jun 11, 2024

Do we need 3 yaml files? Or we can just use one template and pass the Java versions in? This can be taken care of later, if you feel appropriate.

@github-actions github-actions bot added the java label Jun 11, 2024
Copy link
Contributor

@eddyxu eddyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use github action metric to setup java version?

@LuQQiu
Copy link
Collaborator Author

LuQQiu commented Jun 12, 2024

@eddyxu @QianZhu PTAL, thanks

@LuQQiu
Copy link
Collaborator Author

LuQQiu commented Jun 14, 2024

@eddyxu PTAL, thanks

@eddyxu eddyxu merged commit 7cd11b8 into lancedb:main Jun 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants