Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CORS AllowOriginFunc documentation and recipe #164

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Add CORS AllowOriginFunc documentation and recipe #164

merged 1 commit into from
Nov 25, 2020

Conversation

dahu33
Copy link
Contributor

@dahu33 dahu33 commented Nov 16, 2020

This PR adds the CORS middleware AllowOriginFunc documentation and recipe. Related to PR labstack/echo#1651.

@dahu33 dahu33 mentioned this pull request Nov 16, 2020
Merged
lammel
lammel reviewed Nov 20, 2020
View reviewed changes
Copy link
Contributor

@lammel lammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.
Let me know if you change to json as default, will merge then.

website/content/middleware/cors.md Show resolved Hide resolved
@lammel
Copy link
Contributor

lammel commented Nov 22, 2020

Please also rebase as some PRs were merged lately.

@dahu33
Copy link
Contributor Author

dahu33 commented Nov 24, 2020

Please also rebase as some PRs were merged lately.

Done, thanks!

@lammel lammel merged commit 98e1a32 into labstack:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lammel lammel lammel left review comments

@pafuent pafuent pafuent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dahu33 @lammel @pafuent