Request: New bind property for route parameters #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #973 +/- ##
==========================================
+ Coverage 76.66% 76.67% +<.01%
==========================================
Files 27 27
Lines 2216 2229 +13
==========================================
+ Hits 1699 1709 +10
- Misses 396 398 +2
- Partials 121 122 +1
Continue to review full report at Codecov.
|
vishr
reviewed
Jul 24, 2017
bind.go
Outdated
| @@ -75,6 +78,19 @@ func (b *DefaultBinder) Bind(i interface{}, c Context) (err error) { | |||
| return | |||
| } | |||
|
|
|||
| func (b *DefaultBinder) bindRouteData(ptr interface{}, c Context) error { | |||
There was a problem hiding this comment.
Just for consistency can we call it bindPathData()?
There was a problem hiding this comment.
I have renamed as suggested.
vishr
approved these changes
Jul 25, 2017
|
@goenning thanks for your contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed solution for #972
Did I miss something? I'm not quite happy with
bindRouteData, but I didn't find a way to get a map out of the Route parameters.