Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix open redirect vulnerability with AddTrailingSlashWithConfig and RemoveTrailingSlashWithConfig #1775

Merged
merged 3 commits into from
Feb 11, 2021

Conversation

aldas
Copy link
Contributor

@aldas aldas commented Feb 11, 2021

fix open redirect vulnerability with AddTrailingSlashWithConfig and RemoveTrailingSlashWithConfig (#1771)

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #1775 (e3ef5ac) into master (932976d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1775      +/-   ##
==========================================
+ Coverage   89.74%   89.75%   +0.01%     
==========================================
  Files          32       32              
  Lines        2672     2675       +3     
==========================================
+ Hits         2398     2401       +3     
  Misses        175      175              
  Partials       99       99              
Impacted Files Coverage Δ
middleware/slash.go 91.30% <100.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 932976d...e3ef5ac. Read the comment docs.

@aldas aldas requested a review from lammel February 11, 2021 12:11
middleware/slash.go Outdated Show resolved Hide resolved
@lammel
Copy link
Contributor

lammel commented Feb 11, 2021

Great, we have even more table driven tests now.
Looks good! @aldas

@aldas
Copy link
Contributor Author

aldas commented Feb 11, 2021

it if is time to merge, please merge by squashing commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants