Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DefaultHTTPErrorHandler with enabled debug (#1477) #1666

Conversation

lammel
Copy link
Contributor

@lammel lammel commented Nov 5, 2020

This PR will correct the misbehaviour described in issue #1477.

With enabled debug still the correct error will be returned and not overwritten.
Tests are added, where the now expected errors are shown

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #1666 into master will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1666      +/-   ##
==========================================
+ Coverage   83.81%   83.97%   +0.16%     
==========================================
  Files          28       28              
  Lines        1909     1910       +1     
==========================================
+ Hits         1600     1604       +4     
+ Misses        195      194       -1     
+ Partials      114      112       -2     
Impacted Files Coverage Δ
echo.go 84.75% <100.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 095af21...cdd946a. Read the comment docs.

@lammel
Copy link
Contributor Author

lammel commented Nov 5, 2020

Thanks for the review @pafuent .
As only Debug mode is affected, we'll make it happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants