Allow bound interface to be a slice of data #1574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for JSON, XML and Multipart payloads - without and with extra (dummy) query parameters, which make the tests fail (see e.g. labstack#1565)
Do not throw an error when binding to a slice, if binding occurs on path- or query-parameters => data is very likely to be found in the body, which will be bound later Should fix labstack#1356, labstack#1448, labstack#1495 (second case), labstack#1565
Codecov Report
@@ Coverage Diff @@
## master #1574 +/- ##
==========================================
+ Coverage 84.96% 84.97% +0.01%
==========================================
Files 28 28
Lines 2168 2170 +2
==========================================
+ Hits 1842 1844 +2
Misses 211 211
Partials 115 115
Continue to review full report at Codecov.
|
3 tasks
xsadegh
approved these changes
Jun 10, 2020
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
aldas
added a commit
to aldas/echo
that referenced
this pull request
Apr 6, 2021
… not being struct. For path/query params binding we do not try (silently return) to bind when target is not struct. Recreates PR labstack#1574 and fixes labstack#1565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not throw an error when binding to a slice, if binding occurs
on path- or query-parameters
=> data is very likely to be found in the body, which will be bound later
Should fix #1356, fix #1448, partially fix #1495 (second case), fix #1565