Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTP/2 h2c mode (cleartext) #1489

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Conversation

ochanism
Copy link
Contributor

I've added a function "StartH2cServer" for HTTP/2 with h2c mode.
I'd like to run a HTTP/2 echo server on a secure private network, so I don't need a TLS.
However, echo requires a TLS to run a HTTP/2 server, so I've added the function using a h2c library.
Please review my small changes.

@codecov
Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #1489 into master will increase coverage by 0.03%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1489      +/-   ##
==========================================
+ Coverage   84.35%   84.38%   +0.03%     
==========================================
  Files          27       27              
  Lines        2077     2094      +17     
==========================================
+ Hits         1752     1767      +15     
- Misses        212      213       +1     
- Partials      113      114       +1
Impacted Files Coverage Δ
echo.go 85.49% <88.23%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 712b5e4...b4b2801. Read the comment docs.

Copy link
Member

@vishr vishr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can you call it StartH2CServer ?
  • Do you mind updating the docs on echox project

@ochanism
Copy link
Contributor Author

ochanism commented Jan 27, 2020

  • Can you call it StartH2CServer ?

Ok

  • Do you mind updating the docs on echox project

Ok I'm going to update it soon.

@ochanism
Copy link
Contributor Author

I've changed the function name and I've made a pull request for a document.
Please refer to labstack/echox#132

@ochanism ochanism requested review from vishr and removed request for alexaandru January 28, 2020 01:54
@vishr vishr merged commit c2f2e8d into labstack:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants