Refactor DefaultProxyConfig Skipper & WebSocket Check in Context #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishr
approved these changes
Mar 2, 2019
|
@hemachandarv Congrats on your first PR 👍 |
@vishr Thanks! Hopefully the start of many more! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Skipper Config is not provided for Proxy, currently it is set to DefaultLoggerConfig.Skipper. That has been replaced with DefaultProxyConfig.Skipper instead. Even though both refer to the same, it's better to use the one with the same semantics.
Modified IsWebSocket() to convert the header to lower-case before comparing, rather than checking for multiple cases of the same string.
@vishr Your thoughts?