-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IndexAny instead of Split to reduce memory allocation #1640
Conversation
401db93
to
42ef920
Compare
42ef920
to
622f5e3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1640 +/- ##
==========================================
+ Coverage 85.28% 85.30% +0.01%
==========================================
Files 28 28
Lines 2216 2219 +3
==========================================
+ Hits 1890 1893 +3
Misses 212 212
Partials 114 114
Continue to review full report at Codecov.
|
The title says IndexByte but in the code string.IndexAny() is used. What was used in the benchmarks actually? |
sorry, the title is incorrect, I have changed it back and use IndexAny correctly.I will improve the test coverage later |
30b111c
to
64c4950
Compare
@lammel PTAL |
Nice! Will take a look later on. |
hi,any update? @lammel |
Tested for benchmark regressions on the PR branch. PR branch feature/opt-split:
compared to current master:
No regressions seen. PR looks OK. |
benchcmp result:
before:
after: