Use IndexByte instead of Split to reduce memory allocation and improv…

…e performance
labstack · Sep 15, 2020 · 401db93 · 401db93
1 parent 151ed6b
commit 401db93
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/context.go b/context.go
@@ -276,7 +276,10 @@ func (c *context) RealIP() string {
 	}
 	// Fall back to legacy behavior
 	if ip := c.request.Header.Get(HeaderXForwardedFor); ip != "" {
-		return strings.Split(ip, ", ")[0]
+		i := strings.IndexAny(ip, ", ")
+		if i > 0 {
+			return ip[:i]
+		}
 	}
 	if ip := c.request.Header.Get(HeaderXRealIP); ip != "" {
 		return ip

diff --git a/context_test.go b/context_test.go
@@ -871,3 +871,12 @@ func TestContext_RealIP(t *testing.T) {
 		testify.Equal(t, tt.s, tt.c.RealIP())
 	}
 }
+
+func BenchmarkRealIPForHeaderXForwardFor(b *testing.B) {
+	c := context{request: &http.Request{
+		Header: http.Header{HeaderXForwardedFor: []string{"127.0.0.1, 127.0.1.1, "}},
+	}}
+	for i := 0; i < b.N; i++ {
+		c.RealIP()
+	}
+}