fix(runtime): zombie processes caused by inappropriate way of depende…

…ncies upload (#1973)
labring · Jun 3, 2024 · 817ac55 · 817ac55
1 parent 6e5da1a
commit 817ac55
Showing 1 changed file with 18 additions and 10 deletions.
diff --git a/runtimes/nodejs/src/support/module-hot-reload.ts b/runtimes/nodejs/src/support/module-hot-reload.ts
@@ -92,11 +92,7 @@ export function installDependency(packageName: string) {
   return new Promise((resolve, reject) => {
     logger.info(`Installing package ${packageName} ...`)
     exec(
-      `cd ${
-        Config.CUSTOM_DEPENDENCY_BASE_PATH
-      } && npm install ${packageName} && (sh ${process.cwd()}/upload-dependencies.sh ${
-        Config.CUSTOM_DEPENDENCY_BASE_PATH
-      } > /dev/null 2>&1) &`,
+      `cd ${Config.CUSTOM_DEPENDENCY_BASE_PATH} && npm install ${packageName}`,
       (error, stdout) => {
         if (error) {
           logger.error(`Error installing package ${packageName}: ${error}`)
@@ -108,6 +104,14 @@ export function installDependency(packageName: string) {
         // }
         logger.info(`Package ${packageName} installed success`)
         resolve(stdout)
+
+        exec(
+          `cd ${
+            Config.CUSTOM_DEPENDENCY_BASE_PATH
+          } && sh ${process.cwd()}/upload-dependencies.sh ${
+            Config.CUSTOM_DEPENDENCY_BASE_PATH
+          } > /dev/null 2>&1`,
+        )
       },
     )
   })
@@ -127,11 +131,7 @@ export function uninstallDependency(packageName: string) {
   return new Promise((resolve, reject) => {
     logger.info(`Uninstalling package ${packageName} ...`)
     exec(
-      `cd ${
-        Config.CUSTOM_DEPENDENCY_BASE_PATH
-      } && npm uninstall ${packageName} && (sh ${process.cwd()}/upload-dependencies.sh ${
-        Config.CUSTOM_DEPENDENCY_BASE_PATH
-      } > /dev/null 2>&1) &`,
+      `cd ${Config.CUSTOM_DEPENDENCY_BASE_PATH} && npm uninstall ${packageName}`,
       (error, stdout) => {
         if (error) {
           logger.error(`Error uninstalling package ${packageName}: ${error}`)
@@ -143,6 +143,14 @@ export function uninstallDependency(packageName: string) {
         // }
         logger.info(`Package ${packageName} uninstalled success`)
         resolve(stdout)
+
+        exec(
+          `cd ${
+            Config.CUSTOM_DEPENDENCY_BASE_PATH
+          } && sh ${process.cwd()}/upload-dependencies.sh ${
+            Config.CUSTOM_DEPENDENCY_BASE_PATH
+          } > /dev/null 2>&1`,
+        )
       },
     )
   })