Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for OTEL Collector #106

Merged
merged 8 commits into from
Jul 3, 2024

Conversation

roopeshsn
Copy link
Contributor

@roopeshsn roopeshsn commented Apr 7, 2024

No additional instrumentation changes are required for the OTEL collector. It receives (supports prometheus metrics format) metrics from Prometheus and exports them to the desired remote backend. I also tested OTEL collector with Grafana cloud.

#105

@roopeshsn
Copy link
Contributor Author

roopeshsn commented Apr 7, 2024

If the end user makes changes to the endpoint field in the otel-collector-config.yml file, then the OTEL collector will export metrics to that backend. So in parallel, one can export metrics to Prometheus backend and visualize them in Grafana in localhost and remote backend (in my case Grafana cloud). I would like to ensure whether this is a desired behavior.

Copy link

@pmoroney pmoroney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Copy link
Contributor

@sanfern sanfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add other architure support (i.e. arm).
We are getting this error 024-05-06T12:04:52.044+0530 error exporterhelper/queue_sender.go:101 Exporting failed. Dropping data. {"kind": "exporter", "data_type": "metrics", "name": "prometheusremotewrite", "error": "Permanent error: Permanent error: context deadline exceeded", "dropped_items": 39} go.opentelemetry.io/collector/exporter/exporterhelper.newQueueSender.func1

dev_environment/cfg/otel-collector-config.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
dev_environment/setup_linux_dev_env.sh Outdated Show resolved Hide resolved
dev_environment/setup_linux_dev_env.sh Outdated Show resolved Hide resolved
@roopeshsn
Copy link
Contributor Author

Add other architure support (i.e. arm). We are getting this error 024-05-06T12:04:52.044+0530 error exporterhelper/queue_sender.go:101 Exporting failed. Dropping data. {"kind": "exporter", "data_type": "metrics", "name": "prometheusremotewrite", "error": "Permanent error: Permanent error: context deadline exceeded", "dropped_items": 39} go.opentelemetry.io/collector/exporter/exporterhelper.newQueueSender.func1

So the OTEL collector works fine in x64 architecture right?

@roopeshsn
Copy link
Contributor Author

Add other architure support (i.e. arm). We are getting this error 024-05-06T12:04:52.044+0530 error exporterhelper/queue_sender.go:101 Exporting failed. Dropping data. {"kind": "exporter", "data_type": "metrics", "name": "prometheusremotewrite", "error": "Permanent error: Permanent error: context deadline exceeded", "dropped_items": 39} go.opentelemetry.io/collector/exporter/exporterhelper.newQueueSender.func1

This issue is not yet fixed by OTEL. But there is a workaround: open-telemetry/opentelemetry-collector-contrib#31910 (comment)

dev_environment/cfg/otel-collector-config.yml Outdated Show resolved Hide resolved
dev_environment/setup_linux_dev_env.sh Show resolved Hide resolved
Copy link
Contributor

@sanfern sanfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exporting to Otel_collector should not default, make it conditional please

dev_environment/Vagrantfile Show resolved Hide resolved
dev_environment/setup_linux_dev_env.sh Show resolved Hide resolved
@sanfern
Copy link
Contributor

sanfern commented Jun 26, 2024

Please update the setup steps in the README file.

@roopeshsn
Copy link
Contributor Author

Hi @sanfern! Made changes as per review comments. Let me know if further changes are required.

Copy link
Contributor

@sanfern sanfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor changes needed, by removing else block.

@@ -7,4 +7,5 @@ configs:
host_l3af_debug_port: '38899'
host_l3afd_code_dir: '/code/l3afd'
traffic_mirroring: 'false'
host_distro_codename: 'jammy'
otel_collector: 'false'
host_distro_codename: 'jammy'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove newline?

dev_environment/setup_linux_dev_env.sh Outdated Show resolved Hide resolved
dev_environment/setup_linux_dev_env.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@sanfern sanfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Roopesh Saravanan <roopeshsaravanan.dev@gmail.com>
Signed-off-by: Roopesh Saravanan <roopeshsaravanan.dev@gmail.com>
Signed-off-by: Roopesh Saravanan <roopeshsaravanan.dev@gmail.com>
Signed-off-by: Roopesh Saravanan <roopeshsaravanan.dev@gmail.com>
Signed-off-by: Roopesh Saravanan <roopeshsaravanan.dev@gmail.com>
Signed-off-by: Roopesh Saravanan <roopeshsaravanan.dev@gmail.com>
Signed-off-by: Roopesh Saravanan <roopeshsaravanan.dev@gmail.com>
Signed-off-by: Roopesh Saravanan <roopeshsaravanan.dev@gmail.com>
@sanfern sanfern merged commit 8ab6d71 into l3af-project:main Jul 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants