Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the FINAL-NOTE in the KYMA.README #18728

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Add the FINAL-NOTE in the KYMA.README #18728

merged 3 commits into from
Jul 17, 2024

Conversation

zhoujing2022
Copy link
Collaborator

@zhoujing2022 zhoujing2022 commented Jul 5, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • add a highlighted NOTE in Readme, it's about the finalization of Kyma monolithic Release & transformation to Kyma modularization.
  • It also needs to be reviewed by Product Manager.

PLEASE DO NOT MERGE

  • Please start the review but don't merge it. Still waiting for the Frame-frog's "Done" in the final change.

@zhoujing2022 zhoujing2022 requested a review from a team as a code owner July 5, 2024 15:00
@netlify Netlify
Copy link

netlify bot commented Jul 5, 2024 •
edited
Loading

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8742748

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 5, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 5, 2024 •
edited
Loading

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 8742748
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/66966dfa022f7d00083ac719
😎 Deploy Preview https://deploy-preview-18728--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zhoujing2022 zhoujing2022 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2024
@zhoujing2022 zhoujing2022 changed the title Add a NOTE in the KYMA.README Add the FINAL-NOTE in the KYMA.README Jul 5, 2024
IwonaLanger
IwonaLanger reviewed Jul 8, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@zhoujing2022 @IwonaLanger
Update README.md
ac44d9a 
Co-authored-by: Iwona Langer <iwona.langer@sap.com>
IwonaLanger
IwonaLanger previously approved these changes Jul 8, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 8, 2024
a-thaler
a-thaler reviewed Jul 16, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@zhoujing2022 @a-thaler
Update README.md
8742748 
Co-authored-by: Andreas Thaler <andreas.thaler01@sap.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 16, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 16, 2024
@zhoujing2022 zhoujing2022 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2024
@kyma-bot kyma-bot merged commit 2cfbaa3 into kyma-project:main Jul 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-thaler a-thaler a-thaler approved these changes

@mmitoraj mmitoraj mmitoraj approved these changes

@IwonaLanger IwonaLanger IwonaLanger left review comments

@varbanv varbanv Awaiting requested review from varbanv

@marco-porru marco-porru Awaiting requested review from marco-porru

@abbi-gaurav abbi-gaurav Awaiting requested review from abbi-gaurav

Assignees

@a-thaler a-thaler

@mmitoraj mmitoraj

@IwonaLanger IwonaLanger

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhoujing2022 @a-thaler @mmitoraj @IwonaLanger @kyma-bot