Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CRA migrations #18628

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Remove CRA migrations #18628

merged 2 commits into from
Apr 2, 2024

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Mar 26, 2024

Description

Changes proposed in this pull request:

  • Remove migrations from CRA

Compass Runtime Agent no longer copies secrets from compass-system and istio-system.
istio-system namespace is still required.

Related issue(s)

kyma-project/application-connector-manager#48

@VOID404 VOID404 requested a review from a team as a code owner March 26, 2024 08:47
Copy link

netlify bot commented Mar 26, 2024

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f7b495f

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 26, 2024
Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit f7b495f
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/66055f2cea178d0008c20555
😎 Deploy Preview https://deploy-preview-18628--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

koala7659
koala7659 previously approved these changes Mar 28, 2024
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 28, 2024
@VOID404 VOID404 requested a review from a team as a code owner March 28, 2024 12:14
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Mar 28, 2024
@VOID404 VOID404 requested a review from koala7659 March 29, 2024 06:51
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants