Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compass-runtime-agent from kyma resources #18606

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Remove compass-runtime-agent from kyma resources #18606

merged 1 commit into from
Mar 27, 2024

Conversation

m00g3n
Copy link
Contributor

@m00g3n m00g3n commented Mar 13, 2024 •
edited
Loading

Description
Remove compass-runtime-agent from kyma resources

Changes proposed in this pull request:

  • compass-runtime-agent resources removed
  • compassconnection documentation removed

Depends on

Related issue(s)

@m00g3n m00g3n added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2024
@m00g3n m00g3n requested a review from a team as a code owner March 13, 2024 14:54
@netlify Netlify
Copy link

netlify bot commented Mar 13, 2024 •
edited
Loading

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 302aa8a

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 13, 2024 •
edited
Loading

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 302aa8a
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/6604082abe415c00083ecb0f
😎 Deploy Preview https://deploy-preview-18606--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2024
@m00g3n m00g3n changed the title trigger tests Remove compass-runtime-agent from kyma resources Mar 22, 2024
@m00g3n m00g3n requested a review from a team as a code owner March 22, 2024 17:37
@m00g3n m00g3n mentioned this pull request Mar 22, 2024
Closed
15 tasks
@mvshao mvshao self-assigned this Mar 25, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 25, 2024
mvshao
mvshao previously approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@mvshao mvshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 27, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 27, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 27, 2024
@m00g3n m00g3n removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
@kyma-bot kyma-bot merged commit 111b19e into kyma-project:main Mar 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grego952 grego952 grego952 approved these changes

@mvshao mvshao mvshao left review comments

Assignees

@mvshao mvshao

@grego952 grego952

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m00g3n @mvshao @grego952 @kyma-bot