Improve the AC module documentation #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grego952
requested review from
mmitoraj,
NHingerl,
IwonaLanger and
nataliasitko
as code owners
kyma-bot
added
the
size/S
grego952
added
area/documentation
koala7659
reviewed
Oct 13, 2023
| @@ -34,15 +34,10 @@ metadata: | |||
| app.kuberentes.io/managed-by: kustomize | |||
| app.kubernetes.io/created-by: application-connector-manager | |||
| name: applicationconnector-sample | |||
| spec: | |||
| disableLegacyConnectivity : "false" | |||
There was a problem hiding this comment.
Example of fully configured CR:
domainName: c-9057319.dev.kyma.ondemand.com
appConnValidator:
logLevel: "info"
logFormat: "json"
appGateway:
proxyTimeout: "10s"
requestTimeout: "10s"
logLevel: "info"
All parametes are optional. The simplest spec is
spec: {}
There was a problem hiding this comment.
For now, I added the simplest spec spec: {}
koala7659
reviewed
Oct 13, 2023
NHingerl
approved these changes
Oct 16, 2023
grego952
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
**NOTE:** At this stage of development, the ApplicationConnector Custom Resource Definition (CRD) contains only one parameter for testing.from the root READMEdisableLegacyConnectivityflagRelated issue(s)
See also #41