Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang version to 1.23.0 #345

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Update golang version to 1.23.0 #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
25628bb
update golang version to 1.23.1
m00g3n Sep 9, 2024
7d29b73
running go mod tidy after updateing to go 1.23
koala7659 Sep 10, 2024
eee21b2
update golint action version
koala7659 Sep 10, 2024
00affee
update golint action version #2
koala7659 Sep 10, 2024
c8caf29
Merge remote-tracking branch 'origin/main' into 317-update-golang-ver…
koala7659 Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gateway.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ jobs:
- name: Set up go environment
uses: actions/setup-go@v4
with:
go-version: 1.22.4
go-version: 1.23.0
- name: Install k3d
env:
K3D_URL: https://github.com/raw/k3d-io/k3d/main/install.sh
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/golangci-lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22.4'
go-version: '1.23.0'
cache: false
- name: golangci-lint
uses: golangci/golangci-lint-action@v4.0.0
uses: golangci/golangci-lint-action@v6.0.0
with:
# Require: The version of golangci-lint to use.
# When `install-mode` is `binary` (default) the value can be v1.2 or v1.2.3 or `latest` to use the latest version.
# When `install-mode` is `goinstall` the value can be v1.2.3, `latest`, or the hash of a commit.
version: v1.56.2
version: v1.58.2

# Optional: working directory, useful for monorepos
# working-directory: somedir
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-k3d-agent-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Set up go environment
uses: actions/setup-go@v4
with:
go-version: 1.22.4
go-version: 1.23.0
- name: install-k3d
env:
K3D_URL: https://github.com/raw/k3d-io/k3d/main/install.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-validation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set up go environment
uses: actions/setup-go@v4
with:
go-version: 1.22.4
go-version: 1.23.0

- name: Run integration tests without lifecycle-manager
run: make -C hack/ci run-without-lifecycle-manager
2 changes: 1 addition & 1 deletion .github/workflows/run-vuln-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ jobs:
- name: vulncheck
uses: golang/govulncheck-action@v1
with:
go-version-input: 1.22.4
go-version-input: 1.23.0
go-package: ./...
2 changes: 1 addition & 1 deletion .github/workflows/validator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
- name: Set up go environment
uses: actions/setup-go@v4
with:
go-version: 1.22.4
go-version: 1.23.0
- name: Install k3d
env:
K3D_URL: https://github.com/raw/k3d-io/k3d/main/install.sh
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build the manager binary
FROM golang:1.22.6-alpine as builder
FROM golang:1.23.0-alpine3.20 as builder

WORKDIR /acm-workspace

Expand Down
2 changes: 1 addition & 1 deletion components/central-application-connectivity-validator/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22.6-alpine as builder
FROM golang:1.23.0-alpine3.20 as builder

ARG DOCK_PKG_DIR=/go/src/github.com/kyma-project/kyma/components/central-application-connectivity-validator
WORKDIR $DOCK_PKG_DIR
Expand Down
2 changes: 1 addition & 1 deletion components/central-application-connectivity-validator/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module github.com/kyma-project/kyma/components/central-application-connectivity-

go 1.22.0

toolchain go1.22.6
toolchain go1.23.0

require (
github.com/gorilla/mux v1.8.1
Expand Down
2 changes: 1 addition & 1 deletion components/central-application-gateway/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22.6-alpine as builder
FROM golang:1.23.0-alpine3.20 as builder

ARG DOCK_PKG_DIR=/go/src/github.com/kyma-project/kyma/components/central-application-gateway
WORKDIR $DOCK_PKG_DIR
Expand Down
2 changes: 1 addition & 1 deletion components/central-application-gateway/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module github.com/kyma-project/kyma/components/central-application-gateway

go 1.22.0

toolchain go1.22.6
toolchain go1.23.0

require (
github.com/gorilla/mux v1.8.1
Expand Down
2 changes: 1 addition & 1 deletion components/compass-runtime-agent/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22.6-alpine as builder
FROM golang:1.23.0-alpine3.20 as builder


ARG DOCK_PKG_DIR=/compass-runtime-agent
Expand Down
2 changes: 1 addition & 1 deletion components/compass-runtime-agent/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module github.com/kyma-project/kyma/components/compass-runtime-agent

go 1.22.0

toolchain go1.22.6
toolchain go1.23.0

require (
github.com/google/uuid v1.6.0
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/kyma-project/application-connector-manager

go 1.22.5
go 1.23.0

require (
github.com/onsi/ginkgo/v2 v2.20.1
Expand Down
2 changes: 1 addition & 1 deletion tests/Dockerfile.compass-runtime-agent
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22.6-alpine as builder
FROM golang:1.23.0-alpine as builder

WORKDIR /compass-test/

Expand Down
2 changes: 1 addition & 1 deletion tests/Dockerfile.connectivity-validator
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22.6-alpine as builder
FROM golang:1.23.0-alpine as builder

WORKDIR /validator-test/

Expand Down
2 changes: 1 addition & 1 deletion tests/Dockerfile.gateway
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22.6-alpine as builder
FROM golang:1.23.0-alpine as builder

WORKDIR /gateway-test/

Expand Down
2 changes: 1 addition & 1 deletion tests/Dockerfile.mockapp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22.6-alpine as builder
FROM golang:1.23.0-alpine as builder

WORKDIR /mock-app/

Expand Down
1 change: 1 addition & 0 deletions tests/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,5 +86,6 @@ replace (
golang.org/x/crypto => golang.org/x/crypto v0.26.0
golang.org/x/net => golang.org/x/net v0.28.0
golang.org/x/text => golang.org/x/text v0.18.0
golang.org/x/time => golang.org/x/time v0.6.0
google.golang.org/protobuf => google.golang.org/protobuf v1.33.0
)
7 changes: 2 additions & 5 deletions tests/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,11 +397,8 @@ golang.org/x/term v0.23.0 h1:F6D4vR+EHoL9/sWAWgAR1H2DcHr4PareCbAaCo1RpuU=
golang.org/x/term v0.23.0/go.mod h1:DgV24QBUrK6jhZXl+20l6UWznPlwAHm1Q1mGHtydmSk=
golang.org/x/text v0.18.0 h1:XvMDiNzPAl0jr17s6W9lcaIhGUfUORdGCNsuLmPG224=
golang.org/x/text v0.18.0/go.mod h1:BuEKDfySbSR4drPmRPG/7iBdf8hvFMuRexcpahXilzY=
golang.org/x/time v0.0.0-20181108054448-85acf8d2951c/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
golang.org/x/time v0.0.0-20190308202827-9d24e82272b4/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
golang.org/x/time v0.0.0-20191024005414-555d28b269f0/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
golang.org/x/time v0.0.0-20220210224613-90d013bbcef8 h1:vVKdlvoWBphwdxWKrFZEuM0kGgGLxUOYcY4U/2Vjg44=
golang.org/x/time v0.0.0-20220210224613-90d013bbcef8/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
golang.org/x/time v0.6.0 h1:eTDhh4ZXt5Qf0augr54TN6suAUudPcawVZeIAPU7D4U=
golang.org/x/time v0.6.0/go.mod h1:3BpzKBy/shNhVucY/MWOyx10tF3SFh9QdLuxbVysPQM=
golang.org/x/tools v0.0.0-20190114222345-bf090417da8b/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
golang.org/x/tools v0.0.0-20190125232054-d66bd3c5d5a6/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
golang.org/x/tools v0.0.0-20190226205152-f727befe758c/go.mod h1:9Yl7xja0Znq3iFh3HoIrodX9oNMXvdceNzlUR8zjMvY=
Expand Down
Loading