Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed {{}} to -{}- to avoid popular collision #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed {{}} to -{}- to avoid popular collision #5

wants to merge 1 commit into from

Conversation

una
Copy link

@una una commented Jan 5, 2017

Vue.js and other popular libraries like handlebars use {{}}, so I converted it to -{}- to avoid errors that emerged from collision

@una
Changed {{}} to -{}- to avoid popular collision
02f1cb6 
Vue.js and other popular libraries like handlebars use `{{}}`, so I converted it to `-{}-`
@una una closed this Jan 5, 2017
@una una reopened this Jan 5, 2017
@kylestetz
Copy link
Owner

Hi Una! 👋

It would be a backwards compatibility break to switch the default from {{ }} to -{ }-, but I think having an option to change it within Sentencer.configure would be perfect.

Underscore & lodash have _.templateSettings.evaluate, where you can pass a new regular expression to match against. Something like that could work.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@una @kylestetz