Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump sbrscrape. fix odds fetching #71

Merged
merged 1 commit into from
Jan 30, 2023
Merged

bump sbrscrape. fix odds fetching #71

merged 1 commit into from
Jan 30, 2023

Conversation

nkgilley
Copy link
Contributor

fix #70

@nkgilley
Copy link
Contributor Author

It is a little concerning that the urls changed. I expect this is going to happen regularly. I might be able to automatically update the url it needs to scrape from to prevent this.

@kyleskom
Copy link
Owner

This is why I think getting straight from the NBA site is best. Iv been using it for years with no changes.

@kyleskom kyleskom merged commit 3019e6f into kyleskom:master Jan 30, 2023
@kyleskom
Copy link
Owner

Hm this is still broken for me it looks like.

@nkgilley nkgilley deleted the sbrscrape-0.0.3 branch January 31, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError
2 participants
@nkgilley @kyleskom