Games from odds #57
Merged
Games from odds #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will only pull games if also getting odds automatically as well? If I want to manually enter this will pull games from NBA? |
|
Yes, manually entering odds will have it get games from nba. See lines 75 and 76 of main.py |
|
Tested today and worked as expected. Just thinking about if I want to switch off the NBA endpoint. |
|
also updated table format
|
|
Tested new UI works as expected. Merging. |
kyleskom
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If scraping odds from sbrodds, use that data for the games data so we don't have to scrape nba.com which doesn't update until later in the day.
Also skip games without odds