-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sbrscrape package to get odds data from various sportsbooks #53
Conversation
Altered main.py to accept new odds arg
Fixed abbreviated LA Clippers money_line bet options name
…le for todays matches.
…rbee-cz/NBA-Machine-Learning-Sports-Betting into features/odds_json_scraping
This looks amazing. Can't wait to test it soon. |
Can you also update to readme / have a doc for this usage. Looks amazing and tested, works as expected. |
I also really like the front end you have built with flask. Is there anyway we can merge that into this main repo as well? |
One last thing. I think having there be a way to manually enter as well would be good. Leaving the automatic odds as default but a new param to enter manually. |
removed the default so now if |
done |
I went ahead and included the flask app. Right now it displays data from fanduel, draftkings, and betmgm. It will also cache the results for 5 minutes before fetching new data and running the model again. |
Man thank you so much. This PR has many things that I always wanted to add but never had time. Not only that it's done exceptionally well. Kudos. |
Tracking and future discussions. #55 |
pass in
--odds=draftkings
to specify a sportsbook to scrape from.options include: fanduel, draftkings, betmgm, pointsbet, caesars, wynn, bet_rivers_ny
If anyone is interested I have also created a small Flask app to display the output from this tool in the browser.
https://github.com/nkgilley/flask-nba-ml