Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sbrscrape package to get odds data from various sportsbooks #53

Merged
merged 9 commits into from
Jan 9, 2023

Conversation

nkgilley
Copy link
Contributor

@nkgilley nkgilley commented Jan 8, 2023

pass in --odds=draftkings to specify a sportsbook to scrape from.

options include: fanduel, draftkings, betmgm, pointsbet, caesars, wynn, bet_rivers_ny

If anyone is interested I have also created a small Flask app to display the output from this tool in the browser.
https://github.com/nkgilley/flask-nba-ml

image

@kyleskom
Copy link
Owner

kyleskom commented Jan 8, 2023

This looks amazing. Can't wait to test it soon.

main.py Outdated Show resolved Hide resolved
@kyleskom
Copy link
Owner

kyleskom commented Jan 8, 2023

Can you also update to readme / have a doc for this usage. Looks amazing and tested, works as expected.

main.py Outdated Show resolved Hide resolved
@kyleskom
Copy link
Owner

kyleskom commented Jan 8, 2023

I also really like the front end you have built with flask. Is there anyway we can merge that into this main repo as well?

@kyleskom
Copy link
Owner

kyleskom commented Jan 8, 2023

One last thing. I think having there be a way to manually enter as well would be good. Leaving the automatic odds as default but a new param to enter manually.

@nkgilley
Copy link
Contributor Author

nkgilley commented Jan 9, 2023

One last thing. I think having there be a way to manually enter as well would be good. Leaving the automatic odds as default but a new param to enter manually.

removed the default so now if -odds is not given you can enter manually

@nkgilley
Copy link
Contributor Author

nkgilley commented Jan 9, 2023

I also really like the front end you have built with flask. Is there anyway we can merge that into this main repo as well?

done

@nkgilley
Copy link
Contributor Author

nkgilley commented Jan 9, 2023

I went ahead and included the flask app. Right now it displays data from fanduel, draftkings, and betmgm. It will also cache the results for 5 minutes before fetching new data and running the model again.

@kyleskom
Copy link
Owner

kyleskom commented Jan 9, 2023

Man thank you so much. This PR has many things that I always wanted to add but never had time. Not only that it's done exceptionally well. Kudos.

@kyleskom kyleskom self-requested a review January 9, 2023 23:55
@kyleskom kyleskom merged commit a4781dc into kyleskom:master Jan 9, 2023
@kyleskom
Copy link
Owner

Seeing some issues, should be 227
image

@kyleskom
Copy link
Owner

Tracking and future discussions. #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants