-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kellycriterion #230
Kellycriterion #230
Conversation
Will review this soon. One thing I'm thinking though is to have this behind a feature flag. |
I am very new to this, how can I pull thos code into collab and run it to get the kelly criterion results ? |
You can replace the git clone command with this: git clone -b kellycriterion https://github.com/timseymour42/NBA-Machine-Learning-Sports-Betting.git You can also plug the model's win probability into this calculator: The kelly criterion feature is not a part of the main code base just yet. |
Yeah, that's a great idea! I can implement this. Before doing so, I just want to be sure that my code would be used because there is another contributor that implemented the kelly criterion feature. So lmk. |
Yup this will be used / merged if we can have this behind a feature flag. |
Such good work. Thanks guys! I'm working on a native Sentiment agent. Still testing for accuracy. |
Great addition man ! Small question this will work for the money line but what about the points ? |
Currently, the output of the models is a percentage chance that a team will win on the ML. You could raise an issue that you would like to see predictions for the point spread. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and verified. Works as expected!
This breaks when not passing the Need to convert the input to an integer. |
Can you open an issue. |
In this update, I did the following: