-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Days rest: V2 #141
Days rest: V2 #141
Conversation
data.drop(['Score', 'Home-Team-Win', 'TEAM_NAME', 'Date', 'TEAM_NAME.1', 'Date.1', 'OU-Cover'], axis=1, inplace=True) | ||
total = data['OU'] | ||
data.drop(['Score', 'Home-Team-Win', 'TEAM_NAME', 'Date', 'TEAM_NAME.1', 'Date.1', 'OU-Cover', 'OU'], axis=1, inplace=True) | ||
|
||
data['OU'] = np.asarray(total) | ||
data = data.values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the fix
data.drop(['Score', 'Home-Team-Win', 'TEAM_NAME', 'Date', 'TEAM_NAME.1', 'Date.1', 'OU-Cover'], axis=1, | ||
total = data['OU'] | ||
data.drop(['Score', 'Home-Team-Win', 'TEAM_NAME', 'Date', 'TEAM_NAME.1', 'Date.1', 'OU-Cover', 'OU'], axis=1, | ||
inplace=True) | ||
|
||
data['OU'] = np.asarray(total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix
This is awesome! Glad you were able to get this working. I just retrained the NN model and opened PR #142 |
NN model still broken. Ill fix that soon. |
@nkgilley When you trained this new model for the NN did you pull the latest changes from here before training? |
Yea I'm pretty sure that I did. What looks wrong? |
It just still seems to be returning overs for all games. Ill have to take another deeper look. |
from today's games, it's not all overs:
|
So 2 things are happening I think with how close he predictions are to 50% im skeptical. |
can you upload predictions for todays games as mine seems to be playing up |
Hi Kyle,
I've got a quick question. How can i train the model including the 2022 - 2023 season?
Cheers
Em sexta-feira, 17 de março de 2023 às 09:17:30 BRT, dimmos1 ***@***.***> escreveu:
can you upload predictions for todays games as mine seems to be playing up
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
@Marcfeitosa @dimmos1 Please use the discussions tab. This is for the open PR. |
Just got back from more travel and going to try to close this this week. Still need to look at the NN model. Also any reason why we don't use the rest days for the ML predictions as well? |
Im having a hard time getting models I trined to run. What version of python, tensorflow-macos and tensorflow-metal are you using? |
Python 3.9.6, tensorflow-macos 2.11.0. I'm not using tensorflow-metal it doesn't look like, which probably explains why this computer isn't any faster at this than my 10 year old GPU in my old linux box. I'll look into tensorflow-metal tonight. I know I did before but I think I ran into issues. |
Im able to train models but when I run them I get an error. |
I can run the models with and without |
I just got training working with
I'm able to train and run at much faster speeds now 🚀 |
I was able to fix it. It was due to the ML model being out of date. I think the UO on the NN is also fixed |
Wanted to loop back to this quickly |
Nvm I think its all good now |
Looks like days rest is added and tested for both NN and XGB as well as both ML and UO |
@nkgilley If your still interested in contributing shoot me an email kyleskom@buffalo.edu. Id like to discuss some more things moving forward if your interested. |
@nkgilley Here is the updated PR with the fixed UO. If you can train the NN UO model and add it here that would be great. I can't see to get tensorflow to train on my Mac currently.