Unified admin rpc #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rpc from the txsvc
jchappelow
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
LGTM. The join status and list endpoints are semi-public and don't involve txns, but it does seem best in admin regardless.
I suppose we'll wait to merge this until kwilteam/kwil-db#403 is ready?
Yeah they should probably get merged at the same time. We can move the join-status and list to the txsvc if we want; the admin svc has access to the tx svc anyways |
|
Is this going in this week's release? Or after? |
This week |
KwilMachine
pushed a commit
to kwilteam/kwil-js
that referenced
this pull request
Dec 5, 2023
Due to the proto change (here: kwilteam/proto#26 (comment)), KwilD now returns list database an array of the owner, db name, and dbid. There interface on the listDatabases request now matched that, returning the owner as a Uint8Array. BREAKING CHANGE: The kwil.listDatabases() method now returns an array of db-objects (owner, identifier, dbid). Previously, only the db name would be returned when an owner's address was passed to `listDatabases()`.
KwilMachine
pushed a commit
to kwilteam/kwil-js
that referenced
this pull request
Dec 5, 2023
Due to the proto change (here: kwilteam/proto#26 (comment)), KwilD now returns list database an array of the owner, db name, and dbid. There interface on the listDatabases request now matched that, returning the owner as a Uint8Array. BREAKING CHANGE: The kwil.listDatabases() method now returns an array of db-objects (owner, identifier, dbid). Previously, only the db name would be returned when an owner's address was passed to `listDatabases()`.
KwilMachine
pushed a commit
to kwilteam/kwil-js
that referenced
this pull request
Dec 5, 2023
Due to the proto change (here: kwilteam/proto#26 (comment)), KwilD now returns list database an array of the owner, db name, and dbid. There interface on the listDatabases request now matched that, returning the owner as a Uint8Array. BREAKING CHANGE: The kwil.listDatabases() method now returns an array of db-objects (owner, identifier, dbid). Previously, only the db name would be returned when an owner's address was passed to `listDatabases()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
functionsvc, based on the auxiliaryVerifySignaturerpc we have (we will likely expand on these auxiliaries as the gateway's responsibilities / other services we sell grow).