Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.7.5] update gomod for core module version bump #678

Merged
merged 2 commits into from
May 10, 2024
Merged

[v0.7.5] update gomod for core module version bump #678

merged 2 commits into from
May 10, 2024

Conversation

Yaiba
Copy link
Contributor

@Yaiba Yaiba commented Apr 24, 2024

This pr is going to update go.mod which deps on core/v0.1.3(to tag, I'll tag it once I'm sure no more changes will be made to core module).

@Yaiba Yaiba added this to the v0.7.4 milestone Apr 24, 2024
@Yaiba Yaiba changed the title [v0.7.4] update gomod [v0.7.4] update gomod for core module version bump Apr 24, 2024
@Yaiba Yaiba changed the title [v0.7.4] update gomod for core module version bump [WIP] [v0.7.4] update gomod for core module version bump Apr 24, 2024
@jchappelow
Copy link
Member

Might need to alter this to v0.7.5 🤭

@brennanjl
Copy link
Collaborator

Whoops my bad I should've included this

@Yaiba Yaiba modified the milestones: v0.7.4, v0.7.5 Apr 26, 2024
@Yaiba Yaiba changed the title [WIP] [v0.7.4] update gomod for core module version bump [WIP] [v0.7.5] update gomod for core module version bump Apr 26, 2024
@Yaiba
Copy link
Contributor Author

Yaiba commented Apr 26, 2024

my bad as well, I lost track of what's going on yesterday. This will go into v0.7.5

@jchappelow jchappelow mentioned this pull request May 8, 2024
Merged
@Yaiba Yaiba force-pushed the chore/v0.7_update_gomod branch from ef920eb to 6efe0e0 Compare May 8, 2024 19:55
@jchappelow
Copy link
Member

OK to update. Nothing else for v0.7.5 I think.

@Yaiba
Copy link
Contributor Author

Yaiba commented May 9, 2024

OK to update. Nothing else for v0.7.5 I think.

we need #691 backported

@jchappelow
Copy link
Member

OK to update. Nothing else for v0.7.5 I think.

we need #691 backported

Reviewing now.

@jchappelow
Copy link
Member

I think I can tag core/v0.1.3 now, on release-v0.7 branch. #715 does not touch core code. Sound ok @Yaiba ?

a325df6 looks appropriate, although I think last change to core was 4863d69

@Yaiba
Copy link
Contributor Author

Yaiba commented May 10, 2024

I think I can tag core/v0.1.3 now, on release-v0.7 branch. #715 does not touch core code. Sound ok @Yaiba ?

a325df6 looks appropriate, although I think last change to core was 4863d69

yeah good to go

@jchappelow
Copy link
Member

tag: https://github.com/kwilteam/kwil-db/releases/tag/core%2Fv0.1.3

@Yaiba Yaiba changed the title [WIP] [v0.7.5] update gomod for core module version bump [v0.7.5] update gomod for core module version bump May 10, 2024
@Yaiba Yaiba marked this pull request as ready for review May 10, 2024 18:28
@jchappelow
Copy link
Member

Dang, I can't merge because I had last commit

@Yaiba
Copy link
Contributor Author

Yaiba commented May 10, 2024

Dang, I can't merge because I had last commit

lol

KwilLuke
KwilLuke approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@KwilLuke KwilLuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😂

@jchappelow jchappelow merged commit c4e11f5 into kwilteam:release-v0.7 May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KwilLuke KwilLuke KwilLuke approved these changes

@jchappelow jchappelow jchappelow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.5
Development

Successfully merging this pull request may close these issues.
4 participants
@Yaiba @jchappelow @brennanjl @KwilLuke