Skip to content

Rewrite string storage to use index, offset and data columns

Codecov / codecov/project succeeded Nov 16, 2023 in 0s

91.03% (target 80.00%)

View this Pull Request on Codecov

91.03% (target 80.00%)

Details

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (093e627) 90.54% compared to head (6118341) 91.03%.

❗ Current head 6118341 differs from pull request most recent head feb92bb. Consider uploading reports for the commit feb92bb to get more accurate results

Files Patch % Lines
src/storage/store/column.cpp 76.41% 25 Missing ⚠️
src/storage/compression/compression.cpp 70.27% 11 Missing ⚠️
src/include/storage/store/column.h 90.90% 1 Missing ⚠️
src/storage/store/string_column_chunk.cpp 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2304      +/-   ##
==========================================
+ Coverage   90.54%   91.03%   +0.48%     
==========================================
  Files        1020     1012       -8     
  Lines       36515    36001     -514     
==========================================
- Hits        33064    32772     -292     
+ Misses       3451     3229     -222     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.