Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move length function as a rewrite function #3442

Merged
merged 1 commit into from
May 4, 2024

Conversation

andyfengHKU
Copy link
Contributor

This PR moves another function using rewrite function framework. The ultimate goal is to remove if functionName == XXX check in the binder.

@andyfengHKU andyfengHKU force-pushed the length-function-as-rewrite-function branch from 273c02d to 784a3a8 Compare May 3, 2024 20:48
@andyfengHKU andyfengHKU force-pushed the length-function-as-rewrite-function branch from 784a3a8 to b609572 Compare May 4, 2024 17:07
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (b491af2) to head (b609572).
Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3442      +/-   ##
==========================================
+ Coverage   92.59%   92.70%   +0.10%     
==========================================
  Files        1205     1202       -3     
  Lines       44825    44867      +42     
==========================================
+ Hits        41504    41592      +88     
+ Misses       3321     3275      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit 175d383 into master May 4, 2024
19 checks passed
@andyfengHKU andyfengHKU deleted the length-function-as-rewrite-function branch May 4, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants