Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fuzzy matching on test result #3432

Merged
merged 3 commits into from
May 2, 2024
Merged

Conversation

yiyun-sj
Copy link
Collaborator

@yiyun-sj yiyun-sj commented May 1, 2024

Fuzzy (regex) matching on errors

  • changed one old test case (the only one that needed regex)
  • changed the existing ---- error(regex) handling (unused by any test cases) to be recognized as a pattern

Example
we should now be able to run the example from issue (ExtensionErrorTest) but the behaviour of that test changed due to a code update.

@yiyun-sj yiyun-sj force-pushed the allow-fuzzy-matching-on-test branch from 65df759 to 0e7ffe1 Compare May 1, 2024 21:30
@yiyun-sj yiyun-sj requested a review from ray6080 May 1, 2024 21:30
@yiyun-sj yiyun-sj marked this pull request as ready for review May 1, 2024 21:30
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u take a look at the following two tests and rewrite them with regex pattern too?

TinySnbExceptionTest.DeleteNodeWithEdgeErrorTest
TinySnbDeleteNodeTest.DeleteNodeWithConnectedRels

@yiyun-sj
Copy link
Collaborator Author

yiyun-sj commented May 2, 2024

Can u take a look at the following two tests and rewrite them with regex pattern too?

TinySnbExceptionTest.DeleteNodeWithEdgeErrorTest
TinySnbDeleteNodeTest.DeleteNodeWithConnectedRels

done!

@yiyun-sj yiyun-sj linked an issue May 2, 2024 that may be closed by this pull request
@yiyun-sj yiyun-sj merged commit 2e75d25 into master May 2, 2024
17 checks passed
@yiyun-sj yiyun-sj deleted the allow-fuzzy-matching-on-test branch May 2, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing framework improvement
2 participants