Avoid modifying vector in HashIndex::mergeSlot when iterating #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably implementation dependent, but
std::vector::pop_backwill invalidate iterators, even if removing from the back when iterating backwards is safe. This is triggering an assertion in MSVC in debug mode. I've changed it to track how many need to be removed and to remove the elements afterwards.I also removed the
auto entry = *it;part;entrywas already overloaded since theHashIndexEntryViewhas an entry field, and if we're now using an iterator instead of a for each anyway.