Support unwind array #3402
Merged
Support unwind array #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
requested changes
Apr 29, 2024
| @@ -179,3 +179,46 @@ Aida|Alice|Bob|Dan | |||
| {_ID: 0:5, _LABEL: person, ID: 8, fName: Farooq, gender: 2, isStudent: True, isWorker: False, age: 25, eyeSight: 4.500000, birthdate: 1980-10-26, registerTime: 1972-07-31 13:22:30.678559, lastJobDuration: 00:18:00.024, workedHours: [3,4,5,6,7], usedNames: [Fesdwe], courseScoresPerTerm: [[8]], grades: [80,78,34,83], height: 1.510000, u: a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a16} | |||
| {_ID: 0:6, _LABEL: person, ID: 9, fName: Greg, gender: 2, isStudent: False, isWorker: False, age: 40, eyeSight: 4.900000, birthdate: 1980-10-26, registerTime: 1976-12-23 04:41:42, lastJobDuration: 10 years 5 months 13:00:00.000024, workedHours: [1], usedNames: [Grad], courseScoresPerTerm: [[10]], grades: [43,83,67,43], height: 1.600000, u: a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a17} | |||
| {_ID: 0:7, _LABEL: person, ID: 10, fName: Hubert Blaine Wolfeschlegelsteinhausenbergerdorff, gender: 2, isStudent: False, isWorker: True, age: 83, eyeSight: 4.900000, birthdate: 1990-11-27, registerTime: 2023-02-21 13:25:30, lastJobDuration: 3 years 2 days 13:02:00, workedHours: [10,11,12,3,4,5,6,7], usedNames: [Ad,De,Hi,Kye,Orlan], courseScoresPerTerm: [[7],[10],[6,7]], grades: [77,64,100,54], height: 1.323000, u: a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a18} | |||
|
|
|||
| -LOG unwindArrayOfInt | |||
| -STATEMENT MATCH (a:person) UNWIND a.grades as x RETURN x | |||
There was a problem hiding this comment.
Did u try to run this in debug mode. I think will trigger an assertion.
src/binder/bind/read/bind_unwind.cpp
Outdated
| @@ -21,7 +21,8 @@ std::unique_ptr<BoundReadingClause> Binder::bindUnwindClause(const ReadingClause | |||
| auto aliasName = unwindClause.getAlias(); | |||
| std::shared_ptr<Expression> alias; | |||
| if (!skipDataTypeValidation(*boundExpression)) { | |||
| ExpressionUtil::validateDataType(*boundExpression, LogicalTypeID::LIST); | |||
| ExpressionUtil::validateDataType(*boundExpression, | |||
There was a problem hiding this comment.
I don't know why this will work. Technically it shouldn't because unwind operator assuming input will always be a LIST. I think you should cast to LIST if input is an array.
acquamarin
force-pushed
the
support-array-unwind
branch
from
fd5d010
to
b48e794
Compare
andyfengHKU
approved these changes
Apr 29, 2024
andyfengHKU
reviewed
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports unwinding an array.
Closes #3401