-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python UDF for Primitive Types #3390
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is going to happen if a pyhton function has optional arugments or position arguments? How are we going to use them in kuzu?
@acquamarin If we allow Python UDF to have optional or position arguments, we cannot match the right function based on user's parameters with our function framework. So we'll require users to provide all parameters for Python UDF by now. I haven't read much into how Python handles optional arguments, @mxwli could take a look at this case when he gets back to work. |
6f17f99
to
a117478
Compare
57fb1e4
to
9a69c07
Compare
Optional arguments and keyword arguments don't have a very good equivalent in Kuzu, and I'm not sure if we even have a mechanism to handle binding for all possible cases, so it's not handled at the moment. No error is thrown, it's just that we ignore the "optional" property and consider all parameters "mandatory" |
Here's how it's to be used, as well as an explanation of some of its features
Nested types haven't been implemented yet, but it's been decided to be done.