Add Implicit Casting from List to Array #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tests add castcost add cast cost for list->array and array->list skip failed test
mxwli
force-pushed
the
listarrayimplicitcast
branch
from
e1fb500
to
5e1b603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #3248
We've decided not to resolve list literals to arrays, since it's much simpler to just support list -> array implicit casting. As a consequence, implicit casts are now no longer guaranteed to always work.
The mentioned
array_cosine_similarity(a.vector, [6.0, 25.0])call still doesn't work due to a binding error. The corresponding tests are disabled until this is fixed.