Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add primary key information to show_connection #3372

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Add primary key information to show_connection #3372

merged 5 commits into from
Apr 26, 2024

Conversation

manh9203
Copy link
Contributor

@manh9203 manh9203 commented Apr 24, 2024 •
edited
Loading

This PR resolved #2991 and #2660.
What has changed:

  • Add primary keys of source and destination tables to the result of show_connection
  • Support implicit casting for parameters of in query call functions
  • Modify stand alone call to accept literal expression as option values, e.g: CALL threads=1+2, also support implicit casting for these values

@manh9203 manh9203 linked an issue Apr 24, 2024 that may be closed by this pull request
"show connection()" should support anytype-> string implicit cast #2660
Closed
andyfengHKU
andyfengHKU requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. But I wanna take another look.

src/binder/bind/bind_standalone_call.cpp Show resolved Hide resolved
src/binder/expression_visitor.cpp Show resolved Hide resolved
src/binder/bind/read/bind_in_query_call.cpp Outdated Show resolved Hide resolved
@manh9203 manh9203 requested review from andyfengHKU and removed request for andyfengHKU April 25, 2024 19:30
@manh9203 manh9203 changed the title Modify show_connection and support implicit casting for table function parameters Add primary key information to show_connection Apr 26, 2024
@manh9203 manh9203 merged commit d9dcc0a into master Apr 26, 2024
17 checks passed
@manh9203 manh9203 deleted the modify-show-connection branch April 26, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyfengHKU andyfengHKU andyfengHKU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@manh9203 @andyfengHKU