Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extension bugs #3364

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix extension bugs #3364

merged 1 commit into from
Apr 24, 2024

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Apr 23, 2024 •
edited
Loading

This PR fixes the following issues:

  1. When attaching a duckdb database, we throw an exception if the database doesn't exist. Closes Error when attaching a non-existent DuckDB database #3358
  2. Throws an exception message when the given dbtype is not supported. Closes ATTACH Duckdb not working #3360
  3. Throws an exception message when detaching a non-existed database.

@acquamarin acquamarin merged commit 49aa2b7 into master Apr 24, 2024
17 checks passed
@acquamarin acquamarin deleted the extension-fix branch April 24, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyfengHKU andyfengHKU andyfengHKU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ATTACH Duckdb not working Error when attaching a non-existent DuckDB database
2 participants
@acquamarin @andyfengHKU