Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3089 #3344

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Fix #3089 #3344

merged 3 commits into from
Apr 23, 2024

Conversation

manh9203
Copy link
Contributor

This PR resolved #3089 by register all valid logical types for comparison.

@manh9203 manh9203 merged commit b4b7dc6 into master Apr 23, 2024
15 of 17 checks passed
@manh9203 manh9203 deleted the Fix-3089 branch April 23, 2024 20:11
acquamarin pushed a commit that referenced this pull request Apr 24, 2024
@manh9203 @acquamarin
Fix #3089 (#3344)
6483aed 
* Register all valid types for comparison functions

* Add tests

* Remove comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyfengHKU andyfengHKU andyfengHKU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MAP = MAP comparison is not registered, but the comparison can still be executed.
2 participants
@manh9203 @andyfengHKU