Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updating the diskArray nextPipPageIdx when multiple new PIPs are added #3329

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

benjaminwinger
Copy link
Collaborator

Silly mistake on my part here, as I guess I made it unconditionally set the nextPipPageIdx on the updatedLastPIP when doing the pip caching optimization in #3189.

The test suite doesn't have any copies large enough to trigger this, as we only add multiple PIPs in a single transaction when copying 1023 * 16 slots (num AP indexes per pip index page times the number of slots per page), or roughly 58 million primary keys (divided among 256 indexes with 14 entries per slot for an int64 slot).

This should be reproduce-able on the second copy, but won't encounter a failure without doing look-ups on certain keys or doing a third copy.
I'll add a larger copy test in a future PR once the performance has improved a little more, as the multi copy test is already very slow in debug mode.

@ray6080 ray6080 merged commit 8c11c53 into master Apr 21, 2024
17 checks passed
@ray6080 ray6080 deleted the hash-index-pip-fix branch April 21, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants