Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi query with filter result error #3323

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Conversation

ted-wq-x
Copy link
Contributor

query like match (a:Person) match (b:Person) where a.firstName=b.firstName and a.lastName="Chen" return a limit 1; result error, filter a.lastName='Chen' is not effective

@ted-wq-x ted-wq-x changed the title fix multi query with filter result error Fix multi query with filter result error Apr 19, 2024
@andyfengHKU andyfengHKU mentioned this pull request Apr 20, 2024
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ted-wq-x, thanks for the fix. I made a few changes to simplify the code a bit. Once CI passes we are good to go.

@ted-wq-x
Copy link
Contributor Author

Hi @ted-wq-x, thanks for the fix. I made a few changes to simplify the code a bit. Once CI passes we are good to go.

my fault, ut CrossJoinWithFilterPushDownTest query should be MATCH (a:person) MATCH (b:person) where a.fName=b.fName and a.fName is null RETURN a.gender ,in this case ,filter should be pushed down

@andyfengHKU
Copy link
Contributor

Hi @ted-wq-x, thanks for the fix. I made a few changes to simplify the code a bit. Once CI passes we are good to go.

my fault, ut CrossJoinWithFilterPushDownTest query should be MATCH (a:person) MATCH (b:person) where a.fName=b.fName and a.fName is null RETURN a.gender ,in this case ,filter should be pushed down

Whoops I see. I'll do with a separate PR.

@andyfengHKU andyfengHKU merged commit 58b8222 into kuzudb:master Apr 20, 2024
16 of 17 checks passed
@andyfengHKU
Copy link
Contributor

Hi @ted-wq-x, thanks for the fix. I made a few changes to simplify the code a bit. Once CI passes we are good to go.

my fault, ut CrossJoinWithFilterPushDownTest query should be MATCH (a:person) MATCH (b:person) where a.fName=b.fName and a.fName is null RETURN a.gender ,in this case ,filter should be pushed down

Whoops I see. I'll do with a separate PR.

Fix should be available in #3336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants