Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Pyarrow Union Scanning #3315

Merged
merged 7 commits into from
Apr 22, 2024
Merged

Implement Pyarrow Union Scanning #3315

merged 7 commits into from
Apr 22, 2024

Conversation

mxwli
Copy link
Contributor

@mxwli mxwli commented Apr 18, 2024

Implements both dense unions and sparse unions. Makes progress towards #3264

The remaining missing types are:

  • float16
  • decimal

Float16 and Decimal aren't implemented because there isn't a close equivalent in Kuzu.
Float16 is used for compressed storage of floats, while decimals can store high width integers or high precision real numbers. Neither of these things are currently done in Kuzu.

  • pure time types (ie time of the day)

The implementation of Kuzu's time type is currently incomplete.

@mxwli mxwli requested a review from andyfengHKU April 22, 2024 15:01
src/common/arrow/arrow_array_scan.cpp Outdated Show resolved Hide resolved
@mxwli mxwli merged commit 13d08c6 into master Apr 22, 2024
17 checks passed
@mxwli mxwli deleted the pyarrow-union branch April 22, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants