Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for duplicate map keys #3307

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Add check for duplicate map keys #3307

merged 3 commits into from
Apr 18, 2024

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Apr 18, 2024 •
edited
Loading

This PR adds a check for duplicated map keys when creating a map value.
When creating a map, we will firstly create a set.
For each map key:

  1. If the key is inside the set => throws an exception.
  2. If the key is not inside the set => insert to the set.

andyfengHKU
andyfengHKU approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/test_files/tinysnb/projection/single_label.test Show resolved Hide resolved
@acquamarin acquamarin merged commit a3fdcd3 into master Apr 18, 2024
17 checks passed
@acquamarin acquamarin deleted the map-duplicat-keys branch April 18, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyfengHKU andyfengHKU andyfengHKU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acquamarin @andyfengHKU