Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CALL to be readonly=true #3302

Merged

Conversation

OTooleMichael
Copy link
Contributor

@OTooleMichael OTooleMichael commented Apr 17, 2024

Call which is used to set options is only possible in Read/Write connections and does not persist for the Db.

The means that settings cannot be set by a readonly connection. It seems like the majority of the time this doesn't make sense.

eg. in readonly mode we cannot use the followings

  1. CALL enable_semi_mask=false;
  2. CALL recursive_pattern_semantic='trail';
  3. Any of the S3 settings (can't read from S3);
  4. THREADS
  5. TIMEOUT
  6. VAR_LENGTH_EXTEND_MAX_DEPTH

All of these currently seem safe for read instances, and most seem completely for read operations.

I read and agree to the terms under CLA.md

@OTooleMichael
Copy link
Contributor Author

OTooleMichael commented Apr 17, 2024

@andyfengHKU Is it not the whole test block that needs to go. Seems like the "READ ONLY TRANSACTION" is only set up in order to force this error to occur?

I added it in this PR. pity you can't just push to mine. Do you know if there are settings for that?

@andyfengHKU
Copy link
Contributor

@andyfengHKU Is it not the whole test block that needs to go. Seems like the "READ ONLY TRANSACTION" is only set up in order to force this error to occur?

You are right. The entire test case should be removed.

Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also can u add the following to the PR description.

I read and agree to the terms under CLA.md

@andyfengHKU andyfengHKU merged commit 5e84178 into kuzudb:master Apr 17, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants