Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement use database #3300

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Implement use database #3300

merged 5 commits into from
Apr 17, 2024

Conversation

acquamarin
Copy link
Collaborator

No description provided.

andyfengHKU
andyfengHKU approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I assume there should also be a commend to check the default database that is being used?

scripts/antlr4/Cypher.g4.copy Show resolved Hide resolved
src/binder/bind/bind_use_database.cpp Outdated Show resolved Hide resolved
src/processor/map/map_use_database.cpp Outdated Show resolved Hide resolved
src/planner/plan/append_simple.cpp Show resolved Hide resolved
src/binder/bind/read/bind_load_from.cpp Show resolved Hide resolved
@acquamarin acquamarin merged commit fc6659e into master Apr 17, 2024
17 checks passed
@acquamarin acquamarin deleted the use-database branch April 17, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyfengHKU andyfengHKU andyfengHKU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acquamarin @andyfengHKU