Remove 256K page size limit for ftable #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acquamarin
approved these changes
Apr 15, 2024
andyfengHKU
force-pushed
the
remove-256K-page-size-for-ftable
branch
from
f072045
to
5084ce7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #3246.
The core change is to force DataBlock to always take a size as a constructor parameter. In most of the cases this will be
256_PAGE_SIZEbut we do allow allocating more than it.As I'm writing the test, I realize the previous assumption (that a tuple is always small) still holds because an average column size is 16 bytes (considering their fixed size part) and we need more than 16K columns to exceed the limit.
What was problematic and being fixed in this PR is in unFlat tuple block where each block can hold 2048 tuples at max. In such case, we trigger limitation if a tuple has more than 128K in size (average 8 columns).