Fix #3154 #3263
Merged
Fix #3154 #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
approved these changes
Apr 12, 2024
|
|
||
| ~ConnectionQueryAsyncWorker() override = default; | ||
|
|
||
| inline void Execute() override { |
There was a problem hiding this comment.
compiler will inline automatically if the implementation write in header. So no need to mark inline, same for other functions in this file.
| py::gil_scoped_release release; | ||
| auto queryResult = conn->query(statement); | ||
| py::gil_scoped_acquire acquire; | ||
| if (!queryResult->isSuccess()) { |
There was a problem hiding this comment.
I would refactor l60-l65 with l72-l77 into a static function in this cpp file.
There was a problem hiding this comment.
Not sure if you wanna do the same on NodeJS side. I'll let u decide.
There was a problem hiding this comment.
I refactored it for Python. In Node.js I think I'll just keep the two workers as different classes for simplicity instead of creating a common base class.
mewim
force-pushed
the
napi-param-binding
branch
from
b73d2f8
to
1583ea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.