Add Arrow scanning for fixed size list #3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
approved these changes
Apr 12, 2024
|
Looks good 👍 |
|
While reading this code, I found a part of the code that I had overlooked previously. I've applied fixes to other datatypes (will be in a different PR), and am pushing a fix specific to fixed-list to this branch. |
manh9203
force-pushed
the
arrow-scan-fixed-list
branch
from
f7e14cb
to
d7620a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3259 +/- ##
==========================================
+ Coverage 92.61% 92.63% +0.01%
==========================================
Files 1170 1170
Lines 44296 44320 +24
==========================================
+ Hits 41025 41055 +30
+ Misses 3271 3265 -6 ☔ View full report in Codecov by Sentry. |
manh9203
force-pushed
the
arrow-scan-fixed-list
branch
from
d7620a1
to
569b1a4
Compare
andyfengHKU
approved these changes
Apr 15, 2024
manh9203
force-pushed
the
arrow-scan-fixed-list
branch
from
569b1a4
to
8d35606
Compare
manh9203
force-pushed
the
arrow-scan-fixed-list
branch
from
8d35606
to
f0b7f53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolved the issue #3237.