Fix problematic to_arrow tests #3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
LGTM overall. Maybe let @ray6080 take another look tonight?
ray6080
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
UNIONexporting toget_as_arrowAdds
MAPexporting toget_as_arrowFixes
RELexporting toget_as_arrowFixes
INTERVALexporting toget_as_arrowFixes broken tests
_test_node,_test_node_rel,test_marries_tableintest_arrow.py::test_to_arrow_complexDoes not fix
test_to_arrow1, which callsget_as_arrow(-1)(what even is the expected behaviour of this?)Mostly closes #2514
Adds coverage to #2539