Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang tidy and clangd diagnostics check workflow #3254

Merged
merged 10 commits into from
Apr 11, 2024
45 changes: 17 additions & 28 deletions .github/workflows/ci-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -269,30 +269,6 @@ jobs:
call "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvars64.bat"
make javatest

tidy-and-diagnostics:
name: clang tidy & clangd diagnostics check
needs: [clang-format, sanity-checks]
runs-on: kuzu-self-hosted-testing
env:
NUM_THREADS: 32

steps:
- uses: actions/checkout@v3

# For `napi.h` header.
- name: Ensure Node.js dependencies
run: npm install --include=dev
working-directory: tools/nodejs_api

- name: Check for clangd diagnostics
run: make clangd-diagnostics

- name: Run clang-tidy
run: make tidy

- name: Run clang-tidy analyzer
run: make tidy-analyzer

sanity-checks:
name: sanity checks
runs-on: ubuntu-22.04
Expand Down Expand Up @@ -382,17 +358,30 @@ jobs:
needs: [gcc-build-test, clang-build-test]
uses: ./.github/workflows/benchmark-workflow.yml

macos-clang-tidy:
name: macos clang tidy & clangd diagnostics check
clang-tidy:
name: clang tidy & clangd diagnostics check
needs: [clang-format, sanity-checks]
runs-on: self-hosted-mac-x64
runs-on: macos-14
env:
NUM_THREADS: 32
GEN: ninja

steps:
- uses: actions/checkout@v3

- name: Install dependencies
run: |
brew install llvm ninja cmake
export PATH="$(brew --prefix llvm)/bin:$PATH"
echo PATH=$PATH >> $GITHUB_ENV
echo NUM_THREADS=$(sysctl -n hw.ncpu) >> $GITHUB_ENV

- name: Check clang
run: |
which clang
which clang-tidy
which clangd
clang --version

# For `napi.h` header.
- name: Ensure Node.js dependencies
run: npm install --include=dev
Expand Down
Loading