Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support allocations of larger-than-256KB memory buffers #3243

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Apr 10, 2024

Removed the hard limit of memory buffer no larger than 256KB. Now we can store strings larger than 256KB.
This is temporarily done through malloc. Should be optimized later.

Fixed two bugs:

  • incorrect reset of aux buffer in NodeRelExpressionEvaluator.
  • incorrect strlen in MD5Update.

Left todos for later PRs:

  • factorized table still requires the table schema row size less than 256KB. we can remove this too.
  • larger than 256KB memory buffers are not tracked through BM, should fix this.

@ray6080 ray6080 merged commit d59070f into master Apr 10, 2024
18 checks passed
@ray6080 ray6080 deleted the large-mm-blocks branch April 10, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants